Feat: change toy tutorial to kW units - #2223
Conversation
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Flix6x
left a comment
There was a problem hiding this comment.
Nice, my two main comments are:
- to actually not change the toy battery and site power capacities from 500 kVA to 500 kW, and
- to keep the example price data in EUR/MWh, but just scale it to the EUR/kWh sensor unit by explicitly setting the
--unit EUR/MWhCLI option offlexmeasures add beliefs.
Also a question: are there screenshots that would need to be updated in https://github.com/FlexMeasures/screenshots (maybe making FlexMeasures/screenshots#8 obsolete by now)?
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
yes that pr is obsolete. |
Flix6x
left a comment
There was a problem hiding this comment.
Thanks. Unless screenshots still need to be updated, I approve.
Yes there are photos to be updated. I will make the flexmeasures-screenshot PR and link it to this. |
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com> # Conflicts: # documentation/changelog.rst # flexmeasures/cli/tests/test_data_add_fresh_db.py
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
|
@BelhsanHmida is this PR mergeable now? |
I have three more screenshots to generate for the screenshots repo then this can be merged once that's merged. |
…ial-to-kw-units Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com> # Conflicts: # .github/workflows/docker-build.yml # documentation/tut/scripts/run-tutorial-in-docker.sh # documentation/tut/scripts/run-tutorial4-in-docker.sh # documentation/tut/toy-example-process.rst # documentation/tut/toy-example-setup.rst # flexmeasures/cli/data_add.py
Documentation build overview
93 files changed ·
|
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
|
Fixed the stale ID issue in the toy tutorial setup docs. Because template assets are now created before the toy account, the generated toy asset and sensor IDs shifted, so I updated the CLI output, shell-variable flow, sensor links, and referenced IDs to match the fresh tutorial setup. |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
There was a problem hiding this comment.
I approve.
I just want to note that there is a change which this PR is not mentioning, namely the switch of source ID for forecasts in the tutorial, from 4 to 2, and 6 to 3. There is no reason given, but it seems the tutorials pass the GH Action. I assume we did some work on sources previously and this change catches that? If possible, an explanation would be good.
@BelhsanHmida mentioned that IDs for sensors/assets are now higher as we add template assets on startup, but source IDs are decreasing here.
|
Also, I am not sure dates are aligning. When the tutorials are run, all dates would be about
|
Updated the PR description to explain the data-source ID change (forecaster 4→2, reporter 6→3) . I've also opened #2369 for the follow-up |
Signed-off-by: Mohamed Belhsan Hmida <149331360+BelhsanHmida@users.noreply.github.com>
Description
flexmeasures add toy-accountto create kW-scale tutorial power sensors.0.5 MWto500 kW.documentation/changelog.rstLook & Feel
CLI examples now show kW-scale toy assets and schedules, for example:
The rerun toy tutorial plots showed kW labels such as
500kW,0kW,-500kW, and reporter headroom values around300kWto500kW.Simplified schedule output:
Simplified reporter output:
How to test
run the Docker tutorial scripts in order against a fresh isolated stack:
Further Improvements
FlexMeasures/screenshotsrepository.Related Items
Closes #1139.
Sign-off