-
Notifications
You must be signed in to change notification settings - Fork 511
feat: Feature Analytics label grouping (#6067) #7215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5a988cb
feat: Add chart color tokens and getCSSVar utility
talissoncosta 8ae1fe2
feat: Add ColorSwatch component
talissoncosta 686b18b
feat: Add reusable BarChart and ChartTooltip components
talissoncosta 824aa57
feat: Add label-based grouping to Feature Analytics charts
talissoncosta 31fa05f
feat: Add BarChart and MultiSelect Storybook stories
talissoncosta ea963de
fix: Use natural sort order for token generation
talissoncosta da0ff36
fix: Remove hooks-in-loop violation, add unit tests
talissoncosta 29b39c4
refactor: Add useChartColors hook, remove direct getCSSVars calls
talissoncosta 3ba0103
fix: Use useChartColorMap hook in stories, replace inline styles
talissoncosta 2abf581
refactor: Inline getCSSVar into useChartColors, add explanatory comments
talissoncosta d688b51
refactor: Move recharts overrides to dedicated 3rdParty partial
talissoncosta 51eb99c
refactor: Adopt inline var() token constants for charts, drop useChar…
talissoncosta ddc7bf4
chore: Address self-review nits on Feature Analytics PR
talissoncosta 0583838
fix: Labelled chart now matches env-path date axis + guards against n…
talissoncosta 900fe38
fix: Restore env-colour parity with old prod chart
talissoncosta 4f0fe14
fix: Tooltip shows env names + restore readable label contrast
talissoncosta d63943f
refactor: Extract useEnvChartProps, drop BarChart dead props, switch …
talissoncosta 9d311ef
chore: Address review feedback — O(1) day lookup + readable var names
talissoncosta a5a0564
chore: Standardise projectId/featureId to number, use nullish coalescing
talissoncosta ec081f3
fix: SDK filter always visible to prevent layout shift
talissoncosta 819d9df
refactor: Use EmptyState component, drop inline styles
talissoncosta 50e3bc9
fix: Make BarChart story data deterministic for Chromatic stability
talissoncosta 0ec66cd
chore: Remove MultiSelect Storybook stories (defer to dedicated refac…
talissoncosta 040e3d1
feat: Gate labelled chart behind sdk_usage_charts feature flag
talissoncosta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.