Conversation
LouisNillusFC
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rascar-capac)
MaxDaniels
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rascar-capac)
fishingcactus-nathan-istace
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rascar-capac)
lucas-baran
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rascar-capac)
This hasn't been tested but I just wanted to have your opinion on it.
TryGetInstance()can be called instead of usingHasInstancebefore getting the instance.The main benefit is that we can actually use the
FindObjectOfTypein the getter and fetch any instance present in the scene before theAwakeis called.The workaround we used on Corsairs was to change the script execution order, but I find this more convenient.
I'll test it and update the version if you find it useful.
This change is