Experiment: Ruby on Rails' image_tag drop-in support #4
Merged
Conversation
- Add Fileboost::VariantTransformer to map ActiveStorage variant transformations to Fileboost params - Require variant_transformer in lib/fileboost.rb - Update UrlBuilder to accept asset and merge variant params; adjust param normalization (quality validation) - Add extensive specs for variant handling and update existing helper/image_tag/url_builder tests - Define a :thumb named variant in test User model
…_image_tag, examples, docs link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on adding a full support for
image_tagvia patch config