Skip to content

Add independent PDP pinning#155

Open
galargh wants to merge 4 commits into
mainfrom
galargh/independent-pdp-pinning
Open

Add independent PDP pinning#155
galargh wants to merge 4 commits into
mainfrom
galargh/independent-pdp-pinning

Conversation

@galargh

@galargh galargh commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Related to #121

This exposes PDP as an independently pinnable component of foc-devnet. It defaults to using the version bundled with filecoin-services. In particular, the ability to pin pdp independently will be used to test partial ugprade scenarios.

Testing

Questions

  1. For stability profile, should pdp be pinned to latest stable release of pdp, or the version used by latest stable release of filecoin-services?

@FilOzzy FilOzzy added this to FOC Jul 16, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Jul 16, 2026
@galargh
galargh requested review from BigLep and rvagg and removed request for rvagg July 19, 2026 12:01
@galargh
galargh marked this pull request as ready for review July 19, 2026 12:01
@galargh
galargh removed the request for review from BigLep July 19, 2026 12:36
@galargh
galargh marked this pull request as draft July 19, 2026 12:36
Comment thread ci/dependency-profiles.json
Comment thread ci/dependency-profiles.json
@galargh
galargh requested review from BigLep and rvagg July 19, 2026 13:57
@galargh
galargh marked this pull request as ready for review July 19, 2026 13:57
@rvagg

rvagg commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

For stability profile, should pdp be pinned to latest stable release of pdp, or the version used by latest stable release of filecoin-services?

My initial reaction here is filecoin-services, we always bump through there, but we did have one release where we moved it separately. @rjan90 can you weigh in on this one? did we change our release process so that what's the submodule in filecoin-services is what's deployed? Ultimately I think it'll only matter for a small window, but a small window is where it might matter the most.

@rjan90

rjan90 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

My initial reaction here is filecoin-services, we always bump through there, but we did have one release where we moved it separately. @rjan90 can you weigh in on this one?

I believe the separate rollout was the PDP v3.4.0 / filecoin-services v1.2.1 hotfix scenario:

  • PDP v3.4.0 was deployed independently, upgrading the live PDPVerifier proxies from v3.2.0 to v3.4.0.
  • That release removed the USDFC_SYBIL_FEE() getter, while the deployed FWSS v1.2.0 implementation still depended on it.
  • filecoin-services v1.2.1 was then released as a compatibility hotfix. It upgraded FWSS to use a local 0.1 USDFC constant instead of calling the removed getter; it did not perform the PDP upgrade itself.
  • Because v1.2.1 was cut from the v1.2.x release branch, its PDP submodule still pointed to v3.2.0 even though the live PDP proxies were already running v3.4.0. This mismatch is described in filecoin-services #493.
  • The filecoin-services main branch was subsequently synchronized with the final PDP v3.4.0 tag in #489, and that pin was included in the next normal stable release, v1.3.0.

@rvagg rvagg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending some input from @rjan90 to the question of which is the authority; I think fwss version probably
also pls land with conventional commits style commit message(s) when you do land it

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Approved by reviewer

Development

Successfully merging this pull request may close these issues.

4 participants