You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This exposes PDP as an independently pinnable component of foc-devnet. It defaults to using the version bundled with filecoin-services. In particular, the ability to pin pdp independently will be used to test partial ugprade scenarios.
For stability profile, should pdp be pinned to latest stable release of pdp, or the version used by latest stable release of filecoin-services?
My initial reaction here is filecoin-services, we always bump through there, but we did have one release where we moved it separately. @rjan90 can you weigh in on this one? did we change our release process so that what's the submodule in filecoin-services is what's deployed? Ultimately I think it'll only matter for a small window, but a small window is where it might matter the most.
My initial reaction here is filecoin-services, we always bump through there, but we did have one release where we moved it separately. @rjan90 can you weigh in on this one?
I believe the separate rollout was the PDP v3.4.0 / filecoin-services v1.2.1 hotfix scenario:
PDP v3.4.0 was deployed independently, upgrading the live PDPVerifier proxies from v3.2.0 to v3.4.0.
That release removed the USDFC_SYBIL_FEE() getter, while the deployed FWSS v1.2.0 implementation still depended on it.
filecoin-services v1.2.1 was then released as a compatibility hotfix. It upgraded FWSS to use a local 0.1 USDFC constant instead of calling the removed getter; it did not perform the PDP upgrade itself.
Because v1.2.1 was cut from the v1.2.x release branch, its PDP submodule still pointed to v3.2.0 even though the live PDP proxies were already running v3.4.0. This mismatch is described in filecoin-services #493.
The filecoin-services main branch was subsequently synchronized with the final PDP v3.4.0 tag in #489, and that pin was included in the next normal stable release, v1.3.0.
The reason will be displayed to describe this comment to others. Learn more.
approved pending some input from @rjan90 to the question of which is the authority; I think fwss version probably
also pls land with conventional commits style commit message(s) when you do land it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #121
This exposes PDP as an independently pinnable component of foc-devnet. It defaults to using the version bundled with filecoin-services. In particular, the ability to pin pdp independently will be used to test partial ugprade scenarios.
Testing
Questions