ci: make CI builds fast by closing dependency-cache gaps#547
Merged
Conversation
gcc was built from source (~58 min/job) because the FairMQ buildcache mirror is only configured inside the env yaml, while gcc is installed before the env is created. - register the mirror globally after spack setup so "Install GCC" pulls the compiler as a binary - pin runners to ubuntu-24.04 so the weekly buildcache and weekday CI share an image and concretize to matching hashes - bump setup-spack to v3 to match the update-index job
The push trigger had a path filter but no branch filter, so any PR-branch push touching those paths (e.g. a dependabot rebase pulling in setup-deps changes) launched the full fresh buildcache matrix concurrently with CI. - restrict the push trigger to branches [dev, master] - frees runners for CI; the cache still refreshes via cron and on dev/master
FairMQ's own sources (library, examples, tests) were recompiled from scratch in every matrix job on every push. - add hendrikmuhs/ccache-action to build, sanitizers and static-analysis jobs - set CMAKE_C/CXX_COMPILER_LAUNCHER=ccache so cmake routes through it - key the cache per (job, env, gcc) since ccache hashes the compiler
Reusing concretization between the weekly buildcache (fresh) and weekday CI (reuse) can drift if runner externals change, causing avoidable cache misses. - setup-deps installs from test/ci/locks/<env>-gcc<N>.lock when it exists, skipping concretization for byte-identical hashes; falls back to the spec yaml otherwise - buildcache exports each env's spack.lock as a downloadable artifact so the lockfiles can be regenerated on the ubuntu-24.04 runner and committed - document the manual regeneration flow in test/ci/locks/README.md
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install GCCso the compiler is pulled as a binary instead of built from source; pin runners toubuntu-24.04; bumpsetup-spackv2→v3branches: [dev, master]hendrikmuhs/ccache-action) to build/sanitizers/static-analysis, keyed per (job, env, gcc)test/ci/locks/<env>-gcc<N>.lockwhen present, falling back to the spec yaml; buildcache exports eachspack.lockas an artifact