feat: Add Meta.literal_keys option#1145
Open
rodrigobnogueira wants to merge 1 commit intoFactoryBoy:masterfrom
Open
feat: Add Meta.literal_keys option#1145rodrigobnogueira wants to merge 1 commit intoFactoryBoy:masterfrom
rodrigobnogueira wants to merge 1 commit intoFactoryBoy:masterfrom
Conversation
Add literal_keys Meta option to allow field names containing double underscores without triggering deep context parsing. Closes FactoryBoy#1118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
literal_keysMeta option to allow field names containing double underscores without triggering deep context parsing.Fixes
Changes
literal_keysoption toFactoryOptionsDeclarationSetto respect literal keysInvalidDeclarationErroris raised due to deep context parsing, the error now includes a helpful hint suggestingMeta.literal_keys=['field__name']Example
Verification
test_literal_keys: verifies keys are preserved without splittingtest_literal_keys_inheritance: verifies option inheritancetest_literal_keys_missing_raises_error: verifies helpful error hint