Added manual control of the turret#148
Open
JAMthepersonj wants to merge 9 commits into
Open
Conversation
JAMthepersonj
requested review from
MikeKantrowitz,
armadilloz and
batchen1
as code owners
batchen1
requested changes
May 18, 2026
| private final CommandXboxController controller; | ||
|
|
||
|
|
||
| public ManualTurretMove(TurretSubsystem subsystem, CommandXboxController controller) { |
Contributor
There was a problem hiding this comment.
use a supplier instead of passing the controller, similar to what we're doing with the drive joysticks.
|
|
||
| @Override | ||
| public void execute() { | ||
| subsystem.manualMove(controller.getLeftX()/4); |
Contributor
There was a problem hiding this comment.
make this scaling factor into a constant
| } | ||
| } | ||
| public void manualMove(double input){ | ||
| if((input > 0 && !isAtForwardLimit())||(input < 0 && !isAtReverseLimit())){ |
Contributor
There was a problem hiding this comment.
We may want to add a max value for turret and a min value and check input against it, just in case a limit switch is broken.
…RC4048/Java_2026 into JW-added-manual-turret-control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.