Skip to content

Allow negative marks for a question#706

Open
prathamesh920 wants to merge 3 commits intoFOSSEE:masterfrom
prathamesh920:negative-marks
Open

Allow negative marks for a question#706
prathamesh920 wants to merge 3 commits intoFOSSEE:masterfrom
prathamesh920:negative-marks

Conversation

@prathamesh920
Copy link
Copy Markdown
Contributor

Moderator can set negative marks for a question.
This handles the partial grading situation as well.

Note: This is a basic negative marking feature.
This completely depends on the question attribute negative marks
Negative marks setting from Quiz is not included here(can be done as a separate PR if needed).

closes #333

Moderator can set negative marks for a question.
This handles the partial marks situation as well.
Negative marks will be available only for mcq and mcc questions on the
add question interface.
Also, on the safer side the negative marks are given only to the mcc and
mcq questions at the backend.
@pep8speaks
Copy link
Copy Markdown

Hello @prathamesh920! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1749:80: E501 line too long (80 > 79 characters)

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #706 (f98ad48) into master (4756f86) will increase coverage by 4.58%.
The diff coverage is 85.71%.

❗ Current head f98ad48 differs from pull request most recent head 72e7b76. Consider uploading reports for the commit 72e7b76 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   76.69%   81.28%   +4.58%     
==========================================
  Files          53       40      -13     
  Lines        7684     5732    -1952     
  Branches     1166      884     -282     
==========================================
- Hits         5893     4659    -1234     
+ Misses       1408      741     -667     
+ Partials      383      332      -51     
Impacted Files Coverage Δ
yaksh/models.py 89.23% <80.00%> (+4.06%) ⬆️
yaksh/views.py 71.96% <100.00%> (+1.35%) ⬆️
api/views.py 75.83% <0.00%> (-0.91%) ⬇️
yaksh/bash_stdio_evaluator.py 80.55% <0.00%> (-0.53%) ⬇️
yaksh/cpp_code_evaluator.py 83.67% <0.00%> (-0.49%) ⬇️
yaksh/java_code_evaluator.py 84.00% <0.00%> (-0.47%) ⬇️
yaksh/hook_evaluator.py 78.43% <0.00%> (-0.42%) ⬇️
yaksh/r_code_evaluator.py 79.41% <0.00%> (-0.30%) ⬇️
yaksh/cpp_stdio_evaluator.py 82.35% <0.00%> (-0.26%) ⬇️
yaksh/grader.py 91.34% <0.00%> (-0.25%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53b86c...72e7b76. Read the comment docs.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.72%. Comparing base (e53b86c) to head (72e7b76).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
yaksh/models.py 86.66% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   76.69%   76.72%   +0.03%     
==========================================
  Files          53       53              
  Lines        7684     7694      +10     
  Branches     1166     1167       +1     
==========================================
+ Hits         5893     5903      +10     
  Misses       1408     1408              
  Partials      383      383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Negative marking scheme

4 participants