Skip to content

feat: Hide Dependencies button in modlist - #168

Open
jsongdev wants to merge 3 commits into
EverestAPI:mainfrom
jsongdev:main
Open

jsongdev wants to merge 3 commits into
EverestAPI:mainfrom
jsongdev:main

Conversation

@jsongdev

@jsongdev jsongdev commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Adds a checkbox to hide dependencies.
Screenshot from 2026-09-05 16-32-49
Closes #162

@jsongdev
jsongdev marked this pull request as ready for review September 5, 2026 20:36

@microlith57 microlith57 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! will test shortly

Comment thread src/scenes/modlist.lua Outdated
and
-- only show leaf mods
(not scene.onlyShowLeafMods
or not next(scene.modDependents[mod.info.Name] or {}))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if this didn't hide favourited mods, since that way favouriting a mod acts as a way for the user to express that they use it for something on top of it just being a dependency

for instance, extvars is commonly used as a dependency, but players may care about its standalone functionality and therefore want to see it in the list

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I hadn't thought of whether users would favorite dependencies or not. I included the feature but I'm not too sure how to add it to this PR since I am relatively new to making PR requests.

However, replacing the highlighted text with this block adds the functionality to keep favourited mods shown.

(not scene.onlyShowLeafMods
    or (not next(scene.modDependents[mod.info.Name] or {}) 
    or (mod.info.IsFavorite)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Add filter option in "Manage Mods" page to hide all dependency mods

2 participants