docs(examples): make Langfuse wrapper degrade cleanly on a real server#342
Merged
Merged
Conversation
The wrapper synthesized child spans (extraction, embedding, hybrid recall, rerank, index sync, consolidation) from a mock-only `_detail` field. Against a real EverOS server that field is absent, so those spans rendered with placeholder data — hardcoded model names, token=0, fixed sleep durations — and recall scores fell to 0. Now the per-stage child spans are emitted only when `_detail` is present (the mock, or future native in-core instrumentation). Against a live server only the top-level span per operation is emitted, with real latency and output — no fabricated data. Recall quality (recall_top_score / recall_hit) is derived from the real search response, which already carries a per-hit score, so it works against a live server today, not just the mock. Verified: mock path unchanged (full trace tree, real scores); real-ish path (no `_detail`) emits only top-level spans plus a real recall score. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
When a search returns nothing scored, record recall_hit=0 (span attribute + Langfuse score) instead of omitting it, so genuine empty recalls still show up in recall hit-rate. No top_score is emitted (there is no hit to score). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #339. Makes the Langfuse example wrapper honest against a real EverOS server.
Problem
The wrapper built its child spans (extraction, embedding, hybrid recall, rerank, index sync, consolidation) from a
_detailfield that only the built-in mock returns. Against a real server (EVEROS_BASE_URL) that field is absent, so those spans rendered with placeholder data — hardcoded model names,token=0, fixed sleep durations — and recall scores fell to0.Fix
_detailis present (the mock, or future native in-core instrumentation). Against a live server, only the top-level span per operation is emitted — real latency + output, no fabricated data.recall_top_score/recall_hit) is now derived from the real search response, which already carries a per-hit score — so it works against a live server today, not just the mock.Verification
_detailstripped): only the 4 top-level spans emit, with a real recall score (0.81 / hit=true).Additive, examples-only; no EverOS core changes. Mirrored to the GitHub PR to keep the mirror in sync.