entity-armor-stand-destroy flag is added.#1913
Open
chacho4 wants to merge 1 commit intoEngineHub:masterfrom
Open
entity-armor-stand-destroy flag is added.#1913chacho4 wants to merge 1 commit intoEngineHub:masterfrom
chacho4 wants to merge 1 commit intoEngineHub:masterfrom
Conversation
Joo200
requested changes
Mar 19, 2023
Collaborator
Joo200
left a comment
Joo200
left a comment
There was a problem hiding this comment.
I don't see an issue with adding that flag to WorldGuard.
To add the flag please target the version/7.0.x branch.
| import org.bukkit.entity.Player; | ||
| import org.bukkit.entity.Tameable; | ||
| import org.bukkit.entity.ThrownPotion; | ||
| import org.bukkit.entity.*; |
Collaborator
There was a problem hiding this comment.
Please do not use wildcard imports
| * @param defender armor stand being damaged | ||
| * @return true if the event should be cancelled | ||
| */ | ||
| private boolean checkArmorStandProtection(Entity attacker, ArmorStand defender) { |
Collaborator
There was a problem hiding this comment.
You can generalize the checkItemFrameProctection method and pass a flag to that method.
That way you don't need double methods.
| import org.bukkit.entity.Painting; | ||
| import org.bukkit.entity.Player; | ||
| import org.bukkit.entity.Projectile; | ||
| import org.bukkit.entity.*; |
Collaborator
There was a problem hiding this comment.
Please do not use wildcard imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
entity-armor-stand-destroy flag can be changed by a player so that the player can protect armer stand again explosion.
Evidence: https://youtu.be/xHLtpaDZ3po