Determine smeltable items dynamically (for pipes inputting items into furnaces)#1349
Open
ANRAR4 wants to merge 2 commits intoEngineHub:masterfrom
Open
Determine smeltable items dynamically (for pipes inputting items into furnaces)#1349ANRAR4 wants to merge 2 commits intoEngineHub:masterfrom
ANRAR4 wants to merge 2 commits intoEngineHub:masterfrom
Conversation
added 2 commits
March 30, 2025 16:57
Member
|
This PR currently deadlocks my test server during startup. That would need to be fixed before this can be considered. |
Contributor
Author
|
During my testing I didn't encounter any problems |
Member
|
Firstly, I rebased this on top of current master. Then I ran it on a default-settings Paper server with the 1.21.5 build number 36. The only plugins installed were WorldEdit, WorldGuard, LuckPerms, Vault, and this built PR of CraftBook. What specifically happens is the server stops responding, and starts consuming all available memory (32GB, in this case). It then ends up stalled in GC threads, preventing even the watchdog from killing the server due to the stall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously suggested in #1344 the changes replace the switch case statements for determining items smeltable and cookable inside a furnace, which are used to check if an item can be put inside a furnace, with comparisons to lists of the available smelting/cooking/blastsmelting recipes, as the hardcoded lists tend to be outdated.