Support MC RGB colors in conversion to ANSI color codes#1373
Open
Pieter12345 wants to merge 2 commits intoEngineHub:masterfrom
Open
Support MC RGB colors in conversion to ANSI color codes#1373Pieter12345 wants to merge 2 commits intoEngineHub:masterfrom
Pieter12345 wants to merge 2 commits intoEngineHub:masterfrom
Conversation
Contributor
|
You're using a non-capturing parentheses group, so we get this: |
Contributor
Author
I'm not using a non-capturing parenthesis group (see inner part of |
0b963c4 to
65554a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds conversion from MC RGB colors to ANSI color codes. The catch is that Windows command prompt does not show these colors, so it might still make sense to convert these to the nearest available ANSI colors. If you use Linux or Mac OS, could you test whether RGB color codes now work in cmdline mode and leave a comment with the result? Thanks!