Use ash' built-in "linked" feature for static linking#84
Open
MarijnS95 wants to merge 1 commit into
Open
Conversation
All the code here to define an `extern "system"` symbol for `vkGetInstanceProcAddr` and use it inside `Entry` (via `StaticFn`) was included in Ash release `0.35` (the minimum compatbile with `ash-molten` already) to make it much more trivial to static-link on various platforms, including against `MoltenVK` here. This change makes the `lib.rs` portion of `MoltenVK` pretty much useless as it's only forwarding the call (and `load()` should perhaps be renamed?), should we rethink the structure of the crate a bit.
Contributor
Author
Oh, err, I forgot that this implies a forced link against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the code here to define an
extern "system"symbol forvkGetInstanceProcAddrand use it insideEntry(viaStaticFn) was included in Ash release0.35(the minimum compatbile withash-moltenalready) to make it much more trivial to static-link on various platforms, including againstMoltenVKhere.This change makes the
lib.rsportion ofMoltenVKpretty much useless as it's only forwarding the call (andload()should perhaps be renamed?), should we rethink the structure of the crate a bit.