Skip to content

🎨 Palette: CLI Input Validation and Progress Bar#67

Closed
EiJackGH wants to merge 1 commit into
mainfrom
palette-cli-ux-improvements-1681118148208293051
Closed

🎨 Palette: CLI Input Validation and Progress Bar#67
EiJackGH wants to merge 1 commit into
mainfrom
palette-cli-ux-improvements-1681118148208293051

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

This PR enhances the UX of the Bitcoin Trading Simulation CLI by:

  1. Input Validation: Prevents invalid simulation parameters (e.g., negative days, zero cash) with friendly, colored error messages.
  2. Progress Feedback: Adds a simple, dependency-free progress bar that displays during quiet/long simulations when running in an interactive terminal. This addresses the "frozen" feeling during long runs.
  3. Log Hygiene: Ensures the progress bar is only shown in TTY environments, keeping logs clean for CI/CD or file redirection.

PR created automatically by Jules for task 1681118148208293051 started by @EiJackGH

- Add `validate_inputs` to `bitcoin_trading_simulation.py` to ensure CLI arguments are positive/valid.
- Add text-based progress bar for `--quiet` mode simulations, guarded by `sys.stdout.isatty()` to prevent log pollution.
- Improve error messages with ANSI colors for better visibility.
- Fixes issue where negative inputs caused confusing "Day 0" output or crashes.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant