Skip to content

🎨 Palette: Add accessibility and instructions to Mario game#206

Open
EiJackGH wants to merge 2 commits into
mainfrom
palette/mario-game-accessibility-4053537349410433160
Open

🎨 Palette: Add accessibility and instructions to Mario game#206
EiJackGH wants to merge 2 commits into
mainfrom
palette/mario-game-accessibility-4053537349410433160

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

  • Added aria-live="polite" and aria-atomic="true" to the Mario game score counter.
  • Added a new #instructions text layer beneath the score to explicitly tell users what keyboard inputs are expected ("Press Space or ↑ Arrow to jump").

🎯 Why

Users shouldn't have to guess the controls. Adding visible keyboard bindings prevents frustration when first launching the game. Also, screen reader users should be notified when their score goes up dynamically.

📸 Before/After

(Visual change adds subtle instructional text below the score in the top left corner)

♿ Accessibility

  • Improved screen reader support for the dynamic score updates.
  • Made implicit keyboard bindings explicit and visually discoverable.

PR created automatically by Jules for task 4053537349410433160 started by @EiJackGH

* Added aria-live and aria-atomic to the score indicator.
* Added on-screen text letting users know they can press Space or Arrow up to jump.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

* Removed `venv` from requirements.txt because it's a standard library module and breaks GitHub Actions pip installations.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant