Skip to content

🎨 Palette: Add accessibility and instructions to Mario game UI#204

Open
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-game-a11y-13771026083174511345
Open

🎨 Palette: Add accessibility and instructions to Mario game UI#204
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-game-a11y-13771026083174511345

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What: Added aria-live attributes to the #score element and added explicit on-screen instructions for game controls in src/views/mario-game.njk.
🎯 Why: To ensure screen readers announce score updates dynamically without needing to re-focus, and to make it immediately obvious to users which keys are required to play the game without guesswork.
📸 Before/After: Before, the score lacked accessibility attributes and there was no visual indication of controls. Now, the score is screen-reader friendly and "Press Space or Up Arrow to jump" is visible.
Accessibility: Added aria-live="polite" and aria-atomic="true" to #score so changes are announced non-intrusively. Kept static instructions out of the dynamic region to avoid redundant repetition.


PR created automatically by Jules for task 13771026083174511345 started by @EiJackGH

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant