🎨 Palette: Add keyboard instructions and accessible score to Mario game#175
🎨 Palette: Add keyboard instructions and accessible score to Mario game#175EiJackGH wants to merge 1 commit into
Conversation
Adds an on-screen instruction panel explaining the jump controls, improving discoverability. Also adds `aria-live="polite"` and `aria-atomic="true"` to the score element so that screen readers can announce score updates dynamically without spamming the user. Removes an invalid `venv` entry from `requirements.txt` to unblock pip installation and testing. Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Added an explicitly styled instruction panel (
#instructions) pointing out the "Space or Up Arrow" jump keybindings tomario-game.njk. Additionally, added ARIA attributes to the score component to ensure dynamic announcements. Cleaned up an invalidvenvstandard library module fromrequirements.txtthat was blocking tests.🎯 Why
Discoverability of game controls was non-existent visually, meaning users had to guess or read the source code to find out how to play. Furthermore, the updating score div was not accessible to screen reader technologies. The
requirements.txtfix unblocks continuous integration and local environment setups.📸 Before/After
(Visuals verified locally via Playwright — an instructional panel now sits cleanly in the top right corner over the blue background).
♿ Accessibility
aria-live="polite"andaria-atomic="true"to the<div id="score">element so AT announces score increments efficiently.PR created automatically by Jules for task 11277554602795517407 started by @EiJackGH