Skip to content

🎨 Palette: Add keyboard instructions and ARIA attributes to Mario game#173

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-game-a11y-2188352125248422725
Open

🎨 Palette: Add keyboard instructions and ARIA attributes to Mario game#173
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-game-a11y-2188352125248422725

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added a visible UI element to explain jump keyboard controls and applied aria-live attributes to the dynamic score counter.

🎯 Why

Previously, the jump controls were invisible (relying on trial and error), and the score updates were hidden from screen readers, creating a poor experience for new users and those relying on assistive technologies.

📸 Before/After

(Verified visually via Playwright screenshot; a semi-transparent black box appears in the top right saying "Press Space or ↑ to jump").

♿ Accessibility

Added aria-live="polite" and aria-atomic="true" to the #score element to ensure screen readers announce score updates dynamically without interrupting the user.

(Note: Also removed the invalid venv entry from requirements.txt to fix testing environment issues).


PR created automatically by Jules for task 2188352125248422725 started by @EiJackGH

Added a visual hint for keyboard jump controls and made the dynamic score accessible to screen readers via aria-live. Also removed an invalid entry from requirements.txt to fix CI.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant