Skip to content

🎨 Palette: Add keyboard instructions and dynamic score accessibility#172

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette/mario-game-accessibility-6344300784578598795
Open

🎨 Palette: Add keyboard instructions and dynamic score accessibility#172
EiJackGH wants to merge 1 commit into
mainfrom
palette/mario-game-accessibility-6344300784578598795

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added a visible instructional overlay to the Mario game indicating the required keyboard controls, and added ARIA live attributes to the score display. Also fixed a dependency issue in requirements.txt.

🎯 Why

Custom keyboard bindings (like Space/Up Arrow to jump) have no native semantics or visual affordances, leaving users to guess the controls. Additionally, dynamic updates to text (like the score) are not announced by default by screen readers unless specifically marked. Finally, the inclusion of venv in requirements.txt was causing automated build and local setup steps to fail.

📸 Before/After

Before: The user is greeted by a blank screen and a stationary character with no indication of how to start playing.
After: A semi-transparent overlay explicitly states "Press Space or ↑ to Jump" in the upper right.

♿ Accessibility

  • Screen Readers: Added aria-live="polite" and aria-atomic="true" to the #score div. This ensures that screen reader users are notified when the score updates dynamically.
  • Cognitive/Motor: Explicit visual instructions reduce cognitive load by removing the need for trial-and-error to discover the controls.

PR created automatically by Jules for task 6344300784578598795 started by @EiJackGH

- Adds an overlay explaining keyboard controls ("Space or ↑ to Jump")
- Adds `aria-live="polite"` to the `#score` element for screen readers
- Cleans up `venv` from `requirements.txt` to fix pip install failures

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant