Skip to content

🎨 Palette: Improve accessibility and controls discoverability in Mario Game#147

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette/mario-game-accessibility-208456331208737975
Open

🎨 Palette: Improve accessibility and controls discoverability in Mario Game#147
EiJackGH wants to merge 1 commit into
mainfrom
palette/mario-game-accessibility-208456331208737975

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

  • Added a visual hint (#controls) instructing players to "Press Space or ↑ to jump".
  • Added aria-live="polite" and aria-atomic="true" attributes to the #score element so screen readers dynamically announce updates.
  • Removed the invalid venv entry from requirements.txt to fix pip install failures in CI.

🎯 Why

  • Discoverability: New players had to guess the controls; now the interaction is explicit.
  • Accessibility: Screen reader users couldn't track their score previously.
  • CI: The broken requirements.txt was actively blocking builds.

📸 Before/After

(Verified locally with Playwright; the text "Press Space or ↑ to jump" appears below the score).

♿ Accessibility

  • Added dynamic screen-reader score announcements.
  • Improved explicit text instructions for standard keyboard events.

PR created automatically by Jules for task 208456331208737975 started by @EiJackGH

- Added explicit `#controls` instructions for jumping
- Added `aria-live="polite"` and `aria-atomic="true"` to score element
- Fixed CI failure by removing invalid `venv` entry from requirements.txt

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant