Skip to content

🎨 Palette: [UX improvement] Add keyboard shortcut hint and accessible score updates to Mario game#145

Closed
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-game-a11y-ux-6798948445136341386
Closed

🎨 Palette: [UX improvement] Add keyboard shortcut hint and accessible score updates to Mario game#145
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-game-a11y-ux-6798948445136341386

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

What

Added a visible hint Press Space or Up Arrow to jump and ensured that the score display is screen-reader accessible.

Why

New players may not immediately realize what the controls are to play the game. In addition, the real-time score updates were visually accessible but completely silent to screen reader users.

Before/After

Before: No instructions for gameplay, score container lacked aria tags.
After: New instructions added beneath the score and the score is announced nicely via a polite aria live region.

Accessibility

  • Added aria-live="polite" and aria-atomic="true" to #score so real-time numerical updates are announced to assistive tech appropriately without disrupting the flow.

PR created automatically by Jules for task 6798948445136341386 started by @EiJackGH

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant