Skip to content

🎨 Palette: Add accessibility attributes to Mario game score and keyboard hints#132

Closed
EiJackGH wants to merge 1 commit into
mainfrom
palette-ux-mario-a11y-9068865671237893915
Closed

🎨 Palette: Add accessibility attributes to Mario game score and keyboard hints#132
EiJackGH wants to merge 1 commit into
mainfrom
palette-ux-mario-a11y-9068865671237893915

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What:

  • Added aria-live="polite" and aria-atomic="true" to the dynamic score counter.
  • Added a visual text hint below the score (Press Space or Up Arrow to jump).
  • Removed venv from requirements.txt to fix pip install failures during testing.

🎯 Why:

  • Screen readers were previously unable to announce the changing score, leaving visually impaired users without feedback on their progress.
  • New users lacked immediate visual discoverability of the game controls, relying solely on trial and error.
  • The invalid venv dependency prevented automated and local test suites from running successfully.

📸 Before/After:

  • Before: The score was a static <div> without ARIA roles, and the game canvas was empty besides the entities.
  • After: The score includes live ARIA regions, and a helpful, subtle text hint is rendered below the score.

Accessibility:

  • The dynamic score updates will now be read aloud smoothly by screen readers without interrupting other tasks (due to polite).
  • The keyboard hints ensure users know how to interact with the application without needing to guess.

PR created automatically by Jules for task 9068865671237893915 started by @EiJackGH

- Added aria-live and aria-atomic to the score counter
- Added visual keyboard hint for controls
- Fixed Python dependencies for local testing

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant