Repository navigation
[ASIM-6921] Keep the details of errors raised by evaluated JS code - #301
Merged
Merged
Conversation
nicoddemus
added this pull request to stack #302
October 8, 2026 19:56
nicoddemus
marked this pull request as ready for review
October 8, 2026 19:59
|
No base build to compare — fb-ASIM-6921-js-error-details into master |
BeneBr
approved these changes
Oct 9, 2026
nicoddemus
force-pushed
the
fb-ASIM-6921-js-error-details
branch
2 times, most recently
from
October 9, 2026 16:22
e0e0619 to
aa693b4
Compare
nicoddemus
force-pushed
the
fb-ASIM-6921-js-error-details
branch
from
October 9, 2026 16:27
aa693b4 to
a438012
Compare
Errors raised by the code Python evaluates in the graph page, like calling a JS function that doesn't exist or a syntax error, reached the error bridge as a bare "Script error." with no message, location or stack: Chromium hides the details of uncaught errors from scripts injected by `runJavaScript`. Errors raised inside the page's own code were not affected, and all QtWebEngine 5.15 builds in use behave the same. Have a function defined by the page evaluate the scripts instead, so Chromium treats them as the page's own code and the error handler gets the full details, and drop the xfail from the test that caught it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nicoddemus
force-pushed
the
fb-ASIM-6921-js-error-details
branch
from
October 9, 2026 16:35
a438012 to
516bf17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors raised by the code Python evaluates in the graph page reached the error bridge as a bare
"Script error.", with no message, location or stack. Chromium hides the details of uncaught errors from scripts injected byrunJavaScript.Fix: the page defines
qmxgraphEval, which evaluates the script with an indirecteval, keeping global scope and the last statement's value asrunJavaScriptdid.eval_js/eval_js_asyncnow send scripts through it, so Chromium treats them as the page's own code andwindow.onerrorgets the full details.🤖 Generated with Claude Code