[design] #109 UI 수정사항 반영 - #110
Merged
Merged
Conversation
Closed
6 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (3)
Walkthrough잠금 아이콘과 태그 컴포넌트를 추가하고, 테마 토큰과 목업 데이터를 확장했습니다. Changes게시물 및 화면 UI 확장
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant PostCard
participant LockIcon
participant Tag
PostCard->>LockIcon: post.isPrivate가 true일 때 렌더링
PostCard->>Tag: post.tags에서 최대 3개 전달
Tag-->>PostCard: 색상 태그 렌더링
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/asset/icons/LockIcon.jsx`:
- Around line 1-7: Update LockIcon to accept and forward an aria-label prop to
the SVG, then update its PostCard usage to provide “비공개 게시물” so screen readers
announce the private status.
In `@src/components/Tag/Tag.jsx`:
- Line 39: Update the Tag component’s line-height styling to use a theme
line-height token, such as theme.lineHeight.xxs, instead of the hardcoded 1.1
value. Add the token to the theme definition if it does not already exist, then
reference it in the Tag styled component.
- Around line 20-27: Move the Tag component and its supporting color logic from
the shared components area into the post feature at
features/post/components/Tag.jsx, then update PostCard imports to use the
feature-local component. Remove the old shared Tag export/file and keep the
existing label rendering and Chip styling behavior unchanged.
In `@src/features/post/components/PostCard.jsx`:
- Around line 67-76: Update the PostCard layout symbols TitleRow, TagArea, and
Title to prevent narrow-card overflow: enable wrapping where appropriate, allow
the title flex item to shrink with min-width: 0, and apply title ellipsis
styling; alternatively place tags on a separate row while preserving the
existing visual layout.
In `@src/mocks/mockPosts.js`:
- Line 41: Rename the mock post field from onlyMe to isPrivate in
src/mocks/mockPosts.js at lines 41-41, and update the corresponding post.onlyMe
access to post.isPrivate in src/features/post/components/PostCard.jsx at lines
20-20 so the data contract remains consistent.
In `@src/styles/theme.js`:
- Around line 28-36: Update the Sub palette tag color pairs in the theme
definitions so each 10px text foreground/background combination meets at least a
4.5:1 contrast ratio, preferably by darkening the foreground colors or
lightening the backgrounds. Add an automated contrast check covering blue,
yellow, pink, and red pairs to prevent regressions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9fa09311-217c-431a-9325-fee043a8f515
📒 Files selected for processing (5)
src/asset/icons/LockIcon.jsxsrc/components/Tag/Tag.jsxsrc/features/post/components/PostCard.jsxsrc/mocks/mockPosts.jssrc/styles/theme.js
nayeon653
approved these changes
Jul 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☘️ 작업한 이슈
🍀 작업한 내용
LockIcon) 컴포넌트를 추가하고, PostCard에 OnlyMe 속성을 반영해 비공개 글은 제목 옆에 자물쇠가 표시되도록 했습니다.Tag공용 컴포넌트를 생성하고, Figma Dev Mode 대조로 확인한 확정 스펙을 반영했습니다.sub팔레트 기준 6색: 연한(50) 배경 + 진한(100) 글자 페어 (green / blue / yellow / pink / red / grey)sub색상 8종,fontSize.xxs(10px),radius.xs(4px)🍃 작업 포인트