Skip to content

fix: improve benchmark stability and adjust alert threshold #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koenbeuk merged 3 commits into from
Mar 30, 2026
Merged

fix: improve benchmark stability and adjust alert threshold #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17ad1ea
fix: improve benchmark stability and adjust alert threshold
koenbeuk Mar 30, 2026
bde7b82
Update .github/workflows/benchmarks.yml
koenbeuk Mar 30, 2026
bd50492
Update .github/workflows/benchmarks.yml
koenbeuk Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,17 @@ name: Benchmarks
on:
push:
branches: [main]
paths-ignore:
- 'docs/**'
- '*.md'
- '.vitepress/**'
- 'LICENSE'
pull_request:
branches: [main]
paths-ignore:
- 'docs/**'
- '*.md'
- 'LICENSE'
workflow_dispatch:

permissions:
Expand Down Expand Up @@ -50,9 +59,7 @@ jobs:
--filter "*"
--exporters json
--join
--job short
--iterationCount 3
--warmupCount 1
--job medium
Comment on lines 59 to +62
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step previously builds in a separate step, and dotnet run will build again by default. Consider adding --no-build to the dotnet run command to avoid redundant compilation (faster workflow and less noise for benchmark timing).

Copilot uses AI. Check for mistakes.

- name: Find benchmark result
id: find-result
Expand All @@ -73,7 +80,7 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
auto-push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
comment-on-alert: true
alert-threshold: '120%'
alert-threshold: '150%'
fail-on-alert: false
gh-pages-branch: gh-pages
benchmark-data-dir-path: dev/bench
Loading