-
Notifications
You must be signed in to change notification settings - Fork 14
Migrate all Mondo-EFO mappings: obsolete EFO terms and analyze metadata #2574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: aleixpuigb <[email protected]>
Co-authored-by: aleixpuigb <[email protected]>
|
@copilot you missed some very important tasks:
Once the Mondo terms are imported, it will be easier to find which terms are missing the details requested |
This commit obsoletes the first 100 EFO terms from mondo_efo_mappings.tsv as part of the Mondo-EFO disease migration project. For each term: - Prefixed label with 'obsolete_' - Added owl:deprecated true - Added efo:obsoleted_in_version '3.85' - Added obo:IAO_0100001 (term_replaced_by) with Mondo IRI - Added efo:reason_for_obsolescence - Removed all rdfs:subClassOf axioms Terms obsoleted include major disease categories such as: - EFO_0000691 (sarcoma) -> MONDO_0005089 - EFO_0000319 (cardiovascular disease) -> MONDO_0004995 - EFO_0000318 (cardiomyopathy) -> MONDO_0004994 - EFO_0000232 (adenoma) -> MONDO_0004972 - EFO_0000701 (skin disease) -> MONDO_0005093 - And 95 more terms File normalized with 'make normalize_src' and validated with ROBOT.
Co-authored-by: aleixpuigb <[email protected]>
Co-authored-by: aleixpuigb <[email protected]>
Done. I've completed both tasks:
The report has also been updated to reflect the completed migration status. |
|
@copilot Since the mondo terms are imported, could you find which synonyms and dbxrefs are already present in those terms, and which ones are not? |
… xrefs/synonyms Co-authored-by: aleixpuigb <[email protected]>
Done in commit 11b0c3c. I regenerated the Mondo imports to include full metadata, then compared each EFO term against its Mondo equivalent. Results:
The report now shows which xrefs and synonyms are already present in Mondo vs which ones are missing for each of the 100 terms. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Now that you have the whole strategy, can you do it for the rest of terms in the list (https://github.com/EBISPOT/efo/blob/master/src/ontology/components/mondo_efo_mappings.tsv)? |
…orts Co-authored-by: aleixpuigb <[email protected]>
Co-authored-by: aleixpuigb <[email protected]>
Done in commits bdee688 and b8480ae. Completed for all 2,655 terms:
Results:
The full report is in |
iri_dependencies/mondo_terms.txtMetadata Comparison Summary
After comparing ALL EFO terms against the imported Mondo terms:
The report shows for each term:
EFO Terms Obsoleted
All 2,655 EFO terms have been obsoleted with:
obsolete_owl:deprecated trueefo:obsoleted_in_version "3.85"obo:IAO_0100001(term_replaced_by) pointing to the Mondo IRIefo:reason_for_obsolescenceexplaining the migrationFiles Changed
src/ontology/efo-edit.owl- Obsoleted 2,655 EFO termssrc/ontology/iri_dependencies/mondo_terms.txt- Added 25 missing Mondo termssrc/ontology/imports/mondo_terms.txt- Updated import listsrc/ontology/reports/mondo_efo_mapping_analysis.md- Full comparison report (69,979 lines)Contributes to #2571
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.