Fixed edfct for several model functions.#38
Open
JensBaalkilde wants to merge 4 commits intoDoseResponse:masterfrom
Open
Fixed edfct for several model functions.#38JensBaalkilde wants to merge 4 commits intoDoseResponse:masterfrom
JensBaalkilde wants to merge 4 commits intoDoseResponse:masterfrom
Conversation
…mal, weibull1 and weibull2 models.
Import numDeriv. Correct derivative of edfct in braincousens and fplogistic models based on numerical derivation using the numDeriv package.
|
Thanks for pointing out this issue @JensBaalkilde. I have implemented these bug fixes in the re-factored version of drc version 3.3.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed edfct in llogistic, llogistic2, lnormal, logistic, weibull1, weibull2, fplogistic, braincousens, so the derivative in the parameters is correct when type = "absolute". This ensures correct Std. Errors when ED() is called with type = "absolute".