Add support for entity SIDs to triggers which use entity types#3
Open
earthwise01 wants to merge 1 commit into
Open
Add support for entity SIDs to triggers which use entity types#3earthwise01 wants to merge 1 commit into
earthwise01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for using entity SIDs instead of fully-qualified type names to the
entityTypesattributes on Clip Prevention Triggers, Collider Resizers, Only Load if Flag Triggers, and Strict Collision Modifiers. Also makes them list fields in Lönn and gives them a dropdown containing all entity SIDs in the current map.This should both help future-proof compatibility with modded entities (since you don't need to rely on internal type names) and make them easier to use for mappers (since entity SIDs are easier to find and allow the fields to have a dropdown).