fix: normalize template.toml mounts across all 502 blueprints - #1063
Merged
Conversation
- 79 blueprints declared a bare [[config.mounts]] header (one empty array element in TOML) -> replaced with the repo idiom 'mounts = []' - 38 blueprints carried doc-style mount blocks (name/mountPath/description) that don't match the schema (filePath/content) and are inert in Dokploy's template processor -> removed; their named volumes already live in each docker-compose.yml - penpot: duplicate 'expose' map key made its docker-compose.yml invalid YAML -> merged into one expose list After this, validate-template.ts passes for all 502 blueprints. The remaining validate-docker-compose.ts flags are the intentional host-port templates (mail/game/streaming protocols: poste.io, mailu, oryx, fivem, lodestone, etc.) which the validator does not yet model as exceptions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dosubot
Bot
added
size:L
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
…rustdesk The validate-docker-compose CI on this PR was failing on rustdesk's hbbs/hbbr port mappings (21115-21119) — intentional host-published ports for the RustDesk relay/rendezvous protocol, which Traefik cannot route. Adds a '# dokploy: allow-host-ports' top-of-file marker that downgrades the port-mapping errors to warnings for such protocol templates (mail/game/streaming/VPN/remote-desktop), and annotates rustdesk. Other exception templates (poste.io, mailu, oryx, fivem...) can be annotated case-by-case as the weekly audit (#1049) surfaces them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1047 — great report by @DPS0340.
What this fixes (full accounting of the 80 toml + 30 compose failures from the issue):
[[config.mounts]]header (which TOML parses as one empty array element) → normalized to the majority idiommounts = [].name/mountPath/description) that don't match the mounts schema (filePath/content) and are inert in Dokploy's template processor → removed (their named volumes already live in each compose).exposemap key made its docker-compose.yml invalid YAML → merged.Verification:
validate-template.ts --dirpasses for all 502 blueprints (was 80 failing);generate-meta.js --check→ 502 validated. The scheduled audit proposed in #1049 will keep this from regressing.🤖 Generated with Claude Code