fix: migrate esbuild build approval to pnpm 11 - #62
Open
timelis wants to merge 1 commit into
Open
Conversation
timelis
marked this pull request as ready for review
July 16, 2026 16:08
timelis
marked this pull request as draft
July 16, 2026 16:11
timelis
marked this pull request as ready for review
July 16, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onlyBuiltDependenciessetting to pnpm v11'sallowBuildsconfiguration.pnpm-lock.yamlandpnpm-workspace.yamlin the Docker build context and image stages.pnpm@latestinstead of pinning the Docker build to an older pnpm release.Root cause
A clean
docker compose buildcurrently fails in two stages:.dockerignoreexcludespnpm-lock.yaml, even though the Dockerfile copies it.esbuild@0.27.7postinstall script withERR_PNPM_IGNORED_BUILDS.The existing
.npmrcusesonlyBuiltDependencies, which is deprecated in pnpm v11. This change replaces it with the supported project-level configuration:Changes
pnpm-lock.yamlfrom the Docker build context..npmrcwithpnpm-workspace.yamland explicitly allow the esbuild build script.pnpm-workspace.yamlinto both Docker stages before dependency installation.Validation
docker compose build --no-cache11.13.1docker compose up -dpnpm test: 25 tests passedpnpm run type-check: passedgit diff --check: passedpnpm run lint: reports an existing formatting error insrc/server.test.tsand an existing warning insrc/utils/responseFormatter.ts; neither file is changed by this PRCloses #59
Alternative to #60: this fixes the same Docker build failure by migrating the project configuration to pnpm v11 instead of pinning pnpm to v10.
Related core workflow workaround: Dokploy/dokploy#4839