Hotfix v0.29.14: backport 20 bug fixes - #4978
Merged
Merged
Conversation
fix(ui): add cursor pointer style for buttons (cherry picked from commit 0fc7584)
…ting fix: prevent environment form from resetting while editing (cherry picked from commit 73e4fdd)
fix(ui): make interactive icons inside badges clickable again (cherry picked from commit 425d478)
fix: avoid postgres 100-argument limit in findRollbackById (cherry picked from commit 069939e)
fix: avoid postgres 100-argument limit in schedule, volume backup and port queries (cherry picked from commit deebf0f)
…-error-title fix(domains): don't render CDN info message as an error in DNS tooltip (cherry picked from commit 5df820a)
…er-forms fix(ui): persist trigger type selection in GitHub provider forms (cherry picked from commit bb73c6e)
fix(ui): resolve unclickable watch path removal button (cherry picked from commit 018e56a)
fix(ui): prevent collapsed avatar clipping (cherry picked from commit 3b0bdd8)
…ading fix(ui): scope deployment delete loading (cherry picked from commit 2be9e1e)
fix(ui): keep dropdown menus open on window blur (cherry picked from commit 51cb7d2)
fix(ui): show real status code on error page (cherry picked from commit 3835a6f)
…ub-credentials fix(preview-deployment): refetch github provider before authenticating (cherry picked from commit a058d1f)
…yment-metadata fix(schedule): return deployment metadata from runManually and fail early on missing container (cherry picked from commit 11e93dd)
…-on-app-delete fix(application): remove preview deployments when deleting an application (cherry picked from commit 056b698)
fix: invalidate railpack build cache when env changes (cherry picked from commit a123009)
fix: resolve environment variables on application rollback (cherry picked from commit 46c87a2)
fix(requests): guard RequestHost before filtering to avoid crash on malformed logs (cherry picked from commit a0162ab)
fix(ui): widen restore backup dialog to match other backup dialogs (cherry picked from commit 3495fc8)
…-files fix(webhook): include added and removed files in watchPaths validation (cherry picked from commit 3f98208)
dosubot
Bot
added
size:L
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+242
to
+246
| for (const previewDeployment of previewDeploymentsList) { | ||
| try { | ||
| await removePreviewDeployment(previewDeployment.previewDeploymentId); | ||
| } catch (_) {} | ||
| } |
Contributor
There was a problem hiding this comment.
If removing a preview Docker service, Traefik configuration, or filesystem directory fails, this empty catch still allows application deletion to cascade away the preview records, leaving infrastructure running or files behind with no record through which cleanup can be retried.
Knowledge Base Used: Application Deployment Flow
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports 20 bug fixes already merged into canary, cherry-picked in merge order onto main, plus the version bump to v0.29.14. No features, no Drizzle migrations.
Merging this PR triggers the full release pipeline (Docker images, GitHub Release, MCP/CLI/SDK sync). Use a merge commit, not squash, so the cherry-picked commits keep their
-xreferences.Included fixes
Verified locally: clean cherry-picks (no conflicts),
tsc --noEmitpassing inpackages/serverandapps/dokploy, full vitest suite green (658 tests).Greptile Summary
This hotfix backports deployment, scheduling, environment, provider-form, request-log, rollback, and UI corrections and bumps the Dokploy release version.
Confidence Score: 4/5
The PR is not yet safe to merge because failed preview cleanup can still erase its tracking state while leaving infrastructure behind.
Preview cleanup catches individual infrastructure-removal failures and continues to delete the preview record, after which application deletion also cascades any remaining tracking records; failed cleanup therefore cannot be retried through the stored deployment state.
Files Needing Attention: apps/dokploy/server/api/routers/application.ts; packages/server/src/services/preview-deployment.ts
Reviews (2): Last reviewed commit: "Update packages/server/src/utils/schedul..." | Re-trigger Greptile
Context used: