Skip to content

fix(ui): scope deployment delete loading - #4947

Merged
Siumauricio merged 2 commits into
Dokploy:canaryfrom
azizbecha:fix/4945-deployment-delete-loading
Aug 2, 2026
Merged

fix(ui): scope deployment delete loading#4947
Siumauricio merged 2 commits into
Dokploy:canaryfrom
azizbecha:fix/4945-deployment-delete-loading

Conversation

@azizbecha

@azizbecha azizbecha commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What is this PR about?

This PR scopes deployment deletion loading states to the deployments being removed. Previously, the mutation's shared pending state was passed to every delete button, causing all rows to show a spinner. A set of in-flight deployment IDs now lets concurrent deletions independently add and clear their own loading state.

Screen.Recording.2026-07-31.at.2.27.01.PM.mov

Checklist

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Testing

  • pnpm --filter=dokploy typecheck
  • pnpm exec biome check apps/dokploy/components/dashboard/application/deployments/show-deployments.tsx
  • git diff --check

Issues related (if applicable)

Closes #4945

Screenshots (if applicable)

N/A

Greptile Summary

The deletion loading state now tracks deployments independently.

  • Stores all deployment IDs with active deletion requests in a Set.
  • Adds an ID when deletion starts and removes only that ID when it settles.
  • Shows the loading state exclusively on the corresponding deployment’s Delete button.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; each deletion now removes only its own deployment ID from the loading-state Set, so one request settling cannot clear another deployment’s pending indicator.

Reviews (2): Last reviewed commit: "fix(ui): track concurrent deployment del..." | Re-trigger Greptile

@azizbecha
azizbecha requested a review from Siumauricio as a code owner July 31, 2026 23:55
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2026
Comment thread apps/dokploy/components/dashboard/application/deployments/show-deployments.tsx Outdated
@Siumauricio
Siumauricio merged commit 2be9e1e into Dokploy:canary Aug 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete spinner appears on every deployment row

2 participants