fix(ui): scope deployment delete loading - #4947
Merged
Siumauricio merged 2 commits intoAug 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR scopes deployment deletion loading states to the deployments being removed. Previously, the mutation's shared pending state was passed to every delete button, causing all rows to show a spinner. A set of in-flight deployment IDs now lets concurrent deletions independently add and clear their own loading state.
Screen.Recording.2026-07-31.at.2.27.01.PM.mov
Checklist
canarybranch.Testing
pnpm --filter=dokploy typecheckpnpm exec biome check apps/dokploy/components/dashboard/application/deployments/show-deployments.tsxgit diff --checkIssues related (if applicable)
Closes #4945
Screenshots (if applicable)
N/A
Greptile Summary
The deletion loading state now tracks deployments independently.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; each deletion now removes only its own deployment ID from the loading-state Set, so one request settling cannot clear another deployment’s pending indicator.
Reviews (2): Last reviewed commit: "fix(ui): track concurrent deployment del..." | Re-trigger Greptile