Skip to content

fix(ui): persist trigger type selection in GitHub provider forms - #4937

Open
narcisonunez wants to merge 1 commit into
canaryfrom
fix/persist-trigger-type-provider-forms
Open

fix(ui): persist trigger type selection in GitHub provider forms#4937
narcisonunez wants to merge 1 commit into
canaryfrom
fix/persist-trigger-type-provider-forms

Conversation

@narcisonunez

@narcisonunez narcisonunez commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What is this PR about?

Fix: "On Tag" trigger selection is not persisted. The bug is in the form state not in the schema, not in the mutation.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #4888

Screenshots (if applicable)

Greptile Summary

The PR makes the GitHub trigger-type selectors controlled by form state in both application and Compose provider forms.

  • Replaces defaultValue with value so persisted trigger selections appear after form reset.
  • Ignores empty selection values before updating the form field.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (2): Last reviewed commit: "fix(ui): persist trigger type selection ..." | Re-trigger Greptile

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jul 29, 2026
@narcisonunez
narcisonunez force-pushed the fix/persist-trigger-type-provider-forms branch from b07c544 to 15bc4b5 Compare July 29, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

“On Tag” trigger selection is not persisted

1 participant