fix: preserve special chars in compose env file generation - #4934
Open
9MidhunPM wants to merge 1 commit into
Open
fix: preserve special chars in compose env file generation#49349MidhunPM wants to merge 1 commit into
9MidhunPM wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4694
Problem
Special characters like
$$,#,{,}in env var values were beinginterpreted by the shell when writing the
.envfile, causingpa$$wordto become
pawordinside containers.Root cause
getCreateEnvFileCommandinpackages/server/src/utils/builders/compose.tswas passing env var content through shell interpolation when writing to disk.
Fix
Base64-encode the env content in Node before passing it to the shell, then
decode via a quoted heredoc (
<< 'DOKPLOY_EOF'). The quoted delimiterprevents any shell interpolation of the payload.
Testing
Added
apps/dokploy/__test__/compose/env-file-literals.test.tswhich runsthe generated bash command and asserts these values survive intact:
pa$$word!"#$%&/()=?{"nested":{}}MAIL_PASSWORD="abc#de"