Skip to content

feat(icon): enhance icon management for services - #4932

Merged
Siumauricio merged 1 commit into
canaryfrom
feat/add-icons
Jul 28, 2026
Merged

feat(icon): enhance icon management for services#4932
Siumauricio merged 1 commit into
canaryfrom
feat/add-icons

Conversation

@Siumauricio

@Siumauricio Siumauricio commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
  • Updated ShowIconSettings component to handle both application and compose service types.
  • Added new icon column to the compose table in the database.
  • Implemented fetching and updating of icons for services in the environment and application pages.
  • Introduced fetchTemplateLogo function to retrieve logos for templates, improving icon handling for compose services.

What is this PR about?

Please describe in a short paragraph what this PR is about.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

Screenshots (if applicable)

- Updated ShowIconSettings component to handle both application and compose service types.
- Added new icon column to the compose table in the database.
- Implemented fetching and updating of icons for services in the environment and application pages.
- Introduced fetchTemplateLogo function to retrieve logos for templates, improving icon handling for compose services.
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 28, 2026
@Siumauricio
Siumauricio merged commit ba5af51 into canary Jul 28, 2026
4 checks passed
@Siumauricio
Siumauricio deleted the feat/add-icons branch July 28, 2026 22:35
windinternet added a commit to windinternet/dokploy that referenced this pull request Jul 29, 2026
…tatus column

Upstream Dokploy#4932 (icon management) was developed on top of Dokploy#3774 (network
management) which introduced a serviceNetworks jsonb column on the compose
table. Since this branch did not pick Dokploy#3774, the serviceNetworks zod field
in createSchema has no backing column and breaks drizzle's typed schema
validation. Drop the field.

Similarly, findEnvironmentsByProjectId was rewritten to include
'compose.applicationStatus', but the compose table only has 'composeStatus'.
Drop the stale column reference.
windinternet added a commit to windinternet/dokploy that referenced this pull request Jul 29, 2026
Brings in the upstream/canary HEAD (5df820a) as an ancestor of this
branch using -s ours, matching the 2026-07-15 sync policy. The merge
content is intentionally empty; this commit only records that every
cherry-picked upstream commit has been reviewed and either integrated
or explicitly rejected:

  - 32 security fixes (Dokploy#4855-Dokploy#4875): all integrated
  - 8 bug fixes (Dokploy#4626, Dokploy#4847, Dokploy#4876, Dokploy#4877, Dokploy#4911, Dokploy#4924, Dokploy#4929, Dokploy#4931): all integrated
  - 2 AI custom provider (Dokploy#4882): integrated
  - 1 icon management (Dokploy#4932): integrated with serviceNetworks stripped (Dokploy#3774 not picked)
  - SOS / Redis-removal / multi-language cleanup: rejected

After this commit, GitHub will no longer list these upstream commits
as 'ahead/behind' pending sync. Future upstream changes still need
to be re-evaluated per docs/design-docs/2026-07-29-upstream-sync-policy.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant