fix(ui): make interactive icons inside badges clickable again - #4929
Merged
Conversation
dosubot
Bot
added
size:XS
|
Can confirm, ran into the same problem and ran into this PR when searching for a solution |
windinternet
added a commit
to windinternet/dokploy
that referenced
this pull request
Jul 29, 2026
Brings in the upstream/canary HEAD (5df820a) as an ancestor of this branch using -s ours, matching the 2026-07-15 sync policy. The merge content is intentionally empty; this commit only records that every cherry-picked upstream commit has been reviewed and either integrated or explicitly rejected: - 32 security fixes (Dokploy#4855-Dokploy#4875): all integrated - 8 bug fixes (Dokploy#4626, Dokploy#4847, Dokploy#4876, Dokploy#4877, Dokploy#4911, Dokploy#4924, Dokploy#4929, Dokploy#4931): all integrated - 2 AI custom provider (Dokploy#4882): integrated - 1 icon management (Dokploy#4932): integrated with serviceNetworks stripped (Dokploy#3774 not picked) - SOS / Redis-removal / multi-language cleanup: rejected After this commit, GitHub will no longer list these upstream commits as 'ahead/behind' pending sync. Future upstream changes still need to be re-evaluated per docs/design-docs/2026-07-29-upstream-sync-policy.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
the "x" remove button on middleware badges (domain config) and Watch Path badges (all git provider forms) does nothing when clicked: no request, no error, no confirmation, and the item stays there after reload.
Shared cause, not two separate bugs. ( #4909 and #4886 )
Badge's base class includes[&>svg]:pointer-events-none, introduced during the Tailwind v4 / shadcn migration (#4706). This blanket-disables pointer events on every SVG child of a Badge including icons that are explicitly meant to be interactive.The remove icon's
onClickhandler is correct and was never the problem.Since the cause is shared, this single change also fixes the identical bug in:
Bitbucket, generic Git
Bitbucket, generic Git
There is an existing PR that fixes this issue 4827
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4909 and #4886
Screenshots (if applicable)