fix: skip dependency lifecycle scripts during MCP sync - #4838
Closed
timelis wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm install --ignore-scriptsin thesync-versionjob.Dokploy/dokployso the currently failing release workflow can be unblocked independently.Root cause
The workflow installs the latest pnpm globally and then runs
pnpm installin a fresh clone ofDokploy/mcp. With pnpm v11, that install exits withERR_PNPM_IGNORED_BUILDSforesbuild@0.27.7, so the MCP version bump and generated tool update are never committed.The sync step only needs the explicitly invoked
fetch-openapiandgeneratescripts. Dependency lifecycle scripts are not required for those commands, so this change disables them during installation instead of pinning the package manager to pnpm v10.Preferred long-term fix in Dokploy/mcp
The more complete project-level fix belongs in
Dokploy/mcp: migrate its build approval configuration to pnpm v11'sallowBuildsformat and ensure that configuration is included in the Docker build context.This was tested with pnpm
11.13.1anddocker compose build --no-cache. With the lockfile included in the build context andpnpm-workspace.yamlcopied into the image, theesbuildpostinstall script ran successfully, both MCP images built, and both Compose services became healthy.A follow-up pull request in
Dokploy/mcpshould add that configuration, reference this pull request andDokploy/mcp#59, and be merged as the preferred long-term project-level solution. This pull request intentionally uses--ignore-scriptsbecause it is the self-contained fix available inDokploy/dokployalone.Validation
maincheckout.allowBuilds.esbuild: truewith pnpm11.13.1using a no-cache Linux Docker Compose build.node:lts-alpinecontainer:pnpm install --frozen-lockfile --ignore-scriptsgit diff --checkCloses #4837
Related: Dokploy/mcp#59, Dokploy/mcp#60