feat: Support display custome certificate provider - #4613
Open
Hoshino-Yumetsuki wants to merge 5 commits into
Open
feat: Support display custome certificate provider#4613Hoshino-Yumetsuki wants to merge 5 commits into
Hoshino-Yumetsuki wants to merge 5 commits into
Conversation
Comment on lines
+135
to
+137
| } catch { | ||
| return []; | ||
| } |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve #4612
Greptile Summary
Adds certificate-resolver discovery and display for domain configuration.
Confidence Score: 4/5
The PR appears safe to merge, though resolver-discovery failures should be surfaced instead of silently presenting an empty provider list.
The resolver mapping and server authorization paths are coherent, with the remaining non-blocking concern limited to lost diagnostics and misleading empty results when remote configuration retrieval or parsing fails.
Files Needing Attention: packages/server/src/utils/traefik/web-server.ts
Reviews (1): Last reviewed commit: "Merge branch 'Dokploy:canary' into canar..." | Re-trigger Greptile