Skip to content

feat: Support display custome certificate provider - #4613

Open
Hoshino-Yumetsuki wants to merge 5 commits into
Dokploy:canaryfrom
Hoshino-Yumetsuki:canary
Open

feat: Support display custome certificate provider#4613
Hoshino-Yumetsuki wants to merge 5 commits into
Dokploy:canaryfrom
Hoshino-Yumetsuki:canary

Conversation

@Hoshino-Yumetsuki

@Hoshino-Yumetsuki Hoshino-Yumetsuki commented Jun 10, 2026

Copy link
Copy Markdown

Solve #4612

Greptile Summary

Adds certificate-resolver discovery and display for domain configuration.

  • Reads resolver names from local or remote Traefik static configuration.
  • Exposes discovered resolvers through the domain API with organization ownership checks.
  • Presents discovered resolvers as selectable certificate providers while preserving the existing custom-resolver representation.

Confidence Score: 4/5

The PR appears safe to merge, though resolver-discovery failures should be surfaced instead of silently presenting an empty provider list.

The resolver mapping and server authorization paths are coherent, with the remaining non-blocking concern limited to lost diagnostics and misleading empty results when remote configuration retrieval or parsing fails.

Files Needing Attention: packages/server/src/utils/traefik/web-server.ts

Reviews (1): Last reviewed commit: "Merge branch 'Dokploy:canary' into canar..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 10, 2026
Comment on lines +135 to +137
} catch {
return [];
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Resolver discovery errors are hidden

The catch-all converts SSH, file-access, and YAML-parsing errors into an empty resolver list, making configured providers disappear from the selector without giving users or operators any diagnostic that discovery failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant