ENG-2038 Add admin-flagged node card context menu to Obsidian tldraw - #1255
Draft
sid597 wants to merge 5 commits into
Draft
ENG-2038 Add admin-flagged node card context menu to Obsidian tldraw#1255sid597 wants to merge 5 commits into
sid597 wants to merge 5 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discourse-nodeis selectedBehavior boundaries
DefaultStylePanel.includeAllDirectionsis explicit at the new menu call site;embeddedcontrols layout only.matchingRelations.slice(0, 1)uses the same predicate and first match as the previous.find(...), and its counterpart lookup is unchanged.ComponentTypecasts are required because tldraw is typed against React 19 while the Obsidian app runs React 18; plain JSX addsTS2786diagnostics. The repository-wide React type mismatch is intentionally out of scope.Scope
This PR changes seven Obsidian production files only. It adds one load-bearing CSS rule and no test command, test framework, dependency, lockfile change, or standalone model layer.
Linear: https://linear.app/discourse-graphs/issue/ENG-2038/add-admin-flagged-node-card-context-menu-to-obsidian-tldraw
Validation
pnpm --filter @discourse-graphs/obsidian build— built with 0 errorsgit diff --check— passed--color-text-3tokenKnown validation gaps
apps/obsidianhas no test harness, and a deferral ticket plus the ticket owner's acceptance are still requiredcheck-typesremains red with the same 20 pre-existing tldraw/React JSX type-identity diagnostics; no diagnostic is introduced inNodeCardContextMenuorRelationPanel