ENG-2068 Sync and publish node schemas while publishing nodes - #1249
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
eacdc23 to
2f999dc
Compare
ab026af to
05ce8da
Compare
2f999dc to
c642663
Compare
4e8d0a4 to
9792f5d
Compare
dec5cf5 to
2f1ab86
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f1ab864d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const missingNodeSchemas = nodeSchemas.filter( | ||
| (s) => !syncedUids.has(s.localId), | ||
| ); | ||
| result.skippedUnsyncedUids = nodeUids.filter((uid) => !syncedUids.has(uid)); |
There was a problem hiding this comment.
When any requested node has not synced yet, nodeUids has already been intersected with syncedUids, so this predicate can never match and skippedUnsyncedUids is always empty. Consequently, the export dialog and telemetry report no skipped nodes—and may close after publishing only a subset—instead of telling the user to retry; compute the skipped set from the original requested UIDs before replacing nodeUids.
Useful? React with 👍 / 👎.
| if (response.error) { | ||
| internalError({ error: response.error }); | ||
| return result; | ||
| } |
There was a problem hiding this comment.
When a schema row fails—for example because its name conflicts with another concept—upsert_concepts catches the exception and returns a negative ID while leaving response.error null. The existing upsertConceptBatches helper explicitly checks returned IDs below zero, but this path proceeds to grant access and reports the absent schema as synced and published; inspect response.data for these sentinel failures before creating ResourceAccess rows.
Useful? React with 👍 / 👎.
2 participants
https://linear.app/discourse-graphs/issue/ENG-2068/sync-and-publish-node-schemas-while-publishing-nodes
explanation:
https://www.loom.com/share/d92d2c80d10b4ec98745a6223c5778e5
testing:
https://www.loom.com/share/b65354b89d154f8bbfe08e66c8a52116