Skip to content

LIMS-1949: Use parentAutoProcProgramId field#1062

Open
ndg63276 wants to merge 2 commits intomasterfrom
improvement/LIMS-1949/use-parentautoprocprogramid-field
Open

LIMS-1949: Use parentAutoProcProgramId field#1062
ndg63276 wants to merge 2 commits intomasterfrom
improvement/LIMS-1949/use-parentautoprocprogramid-field

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1949

Summary:

It is useful to be able to see a downstream processing job's upstream parent, but at the moment we use the "scaling_id" parameter in the ProcessingJobParameter table, which is a bit flaky. We now have an AutoProcProgram.parentAutoProcProgramId field, which is being populated from about 1st April 2026.

Changes:

  • Re-route all calls to _lookup_autoproc to a new _lookup_parent_autoproc function, which uses the parentAutoProcProgramId field
  • If no parent job is found, fall back to the old method, to avoid all pre-April 2026 jobs being broken
  • Use a config variable to limit falling back to before a certain job, as from now on the parentAutoProcProgramId field should be populated
  • Simplify the old method a little, Big EP was using the program_id instead of the scaling_id, but this seems not to be necessary

To test:

  • Go to a recent data collection with lots of downstream processing jobs, eg /dc/visit/nt44198-3/id/22397399
  • On each downstream job, click the "View Upstream" button, check it opens the Automatic Processing bar if needed and switches to the correct tab
  • Go to an older data collection eg /dc/visit/nt44198-3/id/21167691, repeat the check
  • Add the config variable with a low number eg
$max_appid_without_parent = 123;
  • Repeat the check on the older data collection, it should stop working as you have now disallowed falling back to the old method
  • Now set it to 119440820, and repeat the check on the older data collection, it should work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant