Skip to content

fix(ui): persist trigger type selection in GitHub provider forms - #176

Merged
AminDhouib merged 1 commit into
canaryfrom
port/upr-4937
Jul 31, 2026
Merged

fix(ui): persist trigger type selection in GitHub provider forms#176
AminDhouib merged 1 commit into
canaryfrom
port/upr-4937

Conversation

@AminDhouib

Copy link
Copy Markdown
Member

1:1 port of upstream Dokploy#4937 by @narcisonunez.

The Trigger Type Select in the GitHub provider forms (application and compose) passed both defaultValue and a controlled value, and forwarded field.onChange directly. Radix emits an empty-string change when the select closes/resets, which wiped the selection. The handler now ignores empty values, and the redundant defaultValue is dropped so the field stays controlled.

Applied verbatim to both save-github-provider.tsx and save-github-provider-compose.tsx; no fork adaptations were needed.

@AminDhouib
AminDhouib merged commit 6092712 into canary Jul 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants