Skip to content

add self.mod_stable_weight to function _limit_Vp_change()#307

Merged
amoodie merged 3 commits into
DeltaRCM:developfrom
lbakerstahl:develop
Apr 27, 2026
Merged

add self.mod_stable_weight to function _limit_Vp_change()#307
amoodie merged 3 commits into
DeltaRCM:developfrom
lbakerstahl:develop

Conversation

@lbakerstahl
Copy link
Copy Markdown
Contributor

Currently written as a single array of ones to allow modification of _limit_Vp_change() computation in hooks. Future change idea separate into modify erosion and deposition weighting separately? Potential application example, addition of hard structures which can be deposited on but not eroded, oyster reefs. Not needed for my application but could be useful for others.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.97%. Comparing base (08136a2) to head (10a2161).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
pyDeltaRCM/sed_tools.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #307      +/-   ##
===========================================
- Coverage    79.02%   78.97%   -0.06%     
===========================================
  Files           12       12              
  Lines         2727     2730       +3     
===========================================
+ Hits          2155     2156       +1     
- Misses         572      574       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@amoodie amoodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucille, this looks great and is passing tests (including consistency checks). Two small requests:

To your suggestion for the future, we kind of already have that for erosion with another modifying array. That might be the place to start, but might not cover all use cases, as you mention as well.

@lbakerstahl
Copy link
Copy Markdown
Contributor Author

Andrew, thanks for the feedback and 2 new commits have been added in an attempt to address your requests. A few questions:

-I added documentation for the basic structure of the use. I did not add details for the computation differs for deposition vs erosion. Is this acceptable or would you like more details?

-I have never used Python Black before and manually made changes as opposed to using their checker. Is this acceptable? Changes made include spaces around * and adding new lines when character length increased above what seemed like normal.

And thank you for pointing me to mod_erosion. I was aware of it but had not considered how it was implemented or how it might be used for the kind of scenario I described.

Copy link
Copy Markdown
Member

@amoodie amoodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making those changes. I'll merge as soon as the tests finish.

@amoodie amoodie merged commit 728eb14 into DeltaRCM:develop Apr 27, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants