feat: memtable-backed span export and performance snapshot stores#70
Merged
feat: memtable-backed span export and performance snapshot stores#70
Conversation
- Added `probing-memtable` and `xxhash-rust` as dependencies in `Cargo.toml` and `Cargo.lock`. - Introduced new modules: `actor_store`, `members_store`, `metrics_store`, `performance_store`, and `span_store` for enhanced actor and metrics management. - Implemented functionality for managing actor states and metrics snapshots using memory-mapped files. - Added a benchmark for measuring tracing overhead in `benches/tracing_overhead.rs`. - Updated existing actor context and mailbox to support linked tracing for better observability.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| r = await proxy.cascade(depth=depth + 1, origin=self.label) | ||
| results.append(r) | ||
| except Exception: |
| if proxy is not None: | ||
| try: | ||
| await proxy.cascade(depth=0, origin="external") | ||
| except Exception: |
|
|
||
| try: | ||
| await asyncio.Event().wait() | ||
| except asyncio.CancelledError: |
| burst_task.cancel() | ||
| try: | ||
| await burst_task | ||
| except asyncio.CancelledError: |
|
|
||
| ensure_tracing_for_span_capture() | ||
| except ImportError: | ||
| pass |
- Updated `init_actor_memtable`, `init_members_memtable`, `init_metrics_memtable`, and `init_span_memtable` functions to use `Once` for single initialization, preventing race conditions during concurrent calls. - Improved error handling for hash table creation failures, ensuring clearer logging of issues during initialization. - Enhanced code readability by consolidating initialization logic across multiple stores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probing-memtableandxxhash-rustas dependencies inCargo.tomlandCargo.lock.actor_store,members_store,metrics_store,performance_store, andspan_storefor enhanced actor and metrics management.benches/tracing_overhead.rs.Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)