Centralize runtime loop ownership and refactor transfer_queue#69
Merged
wyeth930203 merged 1 commit intoDeepLink-org:mainfrom Apr 23, 2026
Merged
Centralize runtime loop ownership and refactor transfer_queue#69wyeth930203 merged 1 commit intoDeepLink-org:mainfrom
wyeth930203 merged 1 commit intoDeepLink-org:mainfrom
Conversation
- centralize sync bridge and event-loop ownership in _async_bridge and reject sync wrappers on the active Pulsing event-loop thread - replace transfer_queue partition/task_name/batch_size semantics with topic-scoped exact reads using bucket_id and bucket_capacity - implement fixed-capacity per-bucket ring buffers keyed by sample_idx with incremental field merge and overwrite-oldest behavior - validate bucket_capacity consistency when reusing topic+bucket actors and make bucket resolution more robust for Ray workers - refresh transfer_queue sync/async/Ray examples and rewrite transfer_queue tests around exact-read and ring-buffer semantics - add focused coverage tests for async bridge/runtime, sync_queue, subprocess proxies, ray/torchrun integrations, and transfer_queue edge cases - verified with ./.venv/bin/python -m pytest tests/python --ignore=tests/python/test_chaos.py (567 passed, 1 skipped)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
centralize sync bridge and event-loop ownership in _async_bridge and reject sync wrappers on the active Pulsing event-loop thread
replace transfer_queue partition/task_name/batch_size semantics with topic-scoped exact reads using bucket_id and bucket_capacity
implement fixed-capacity per-bucket ring buffers keyed by sample_idx with incremental field merge and overwrite-oldest behavior
validate bucket_capacity consistency when reusing topic+bucket actors and make bucket resolution more robust for Ray workers
refresh transfer_queue sync/async/Ray examples and rewrite transfer_queue tests around exact-read and ring-buffer semantics
add focused coverage tests for async bridge/runtime, sync_queue, subprocess proxies, ray/torchrun integrations, and transfer_queue edge cases
verified with ./.venv/bin/python -m pytest tests/python --ignore=tests/python/test_chaos.py (567 passed, 1 skipped)
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)