Skip to content

feat: add "Skip physics for dead actors" MCM toggle - #15

Merged
DaymareOn merged 1 commit into
mainfrom
feat/skip-dead-actors
Jun 21, 2026
Merged

DaymareOn merged 1 commit into
mainfrom
feat/skip-dead-actors

Conversation

@DaymareOn

Copy link
Copy Markdown
Owner

MCM portion of the skip-dead-actors feature (tracked in DaymareOn/hdtSMP64#376; plugin side: DaymareOn/hdtSMP64#377).

Adds a boolean toggle on the Simplification page that controls the new FSMP skipDeadActors config setting, wired exactly like the other global options (JMap → configs.xml <smp>smp reset).

Changes (Source/Scripts/FSMPM.psc)

  • keys/defaultValues: add skipDeadActors (default false) to the smp series
  • buildConfigString: bump the smp/solver/wind section boundaries (14/18/22 → 15/19/23)
  • OnPageReset: new AddToggleOptionST("ToggleSkipDeadActors", ...)
  • new State ToggleSkipDeadActors handler
  • GetVersion 307 → 310 (new feature = minor bump) + matching OnVersionUpdate block
  • bundled configs.xml + all presets: add the tag (true in Performance, false elsewhere)

Notes

  • Upgrade migration is handled by the existing flow: OnGameReload → OnConfigInit → initConfig/initMap re-defaults all keys each load, and getTagValue falls back to tagDefaultValue for tags missing from an older configs.xml.
  • Compiled .pex are produced by the CI "Commit Compiled Scripts" step (not committed here).
  • Requires the plugin-side support from hdtSMP64 to have effect.

Adds an MCM toggle on the Simplification page for the new FSMP
skipDeadActors setting. Wired like the other global options: the value
is stored in the JMap, serialized into the <smp> section of configs.xml,
and applied via "smp reset".

- keys/defaultValues: add skipDeadActors (default false) to the smp series
- buildConfigString: bump the smp/solver/wind section boundaries
- OnPageReset + ToggleSkipDeadActors state: the toggle and its handler
- GetVersion 307 -> 310 (new feature = minor bump) + OnVersionUpdate block
- bundled configs.xml + presets: add the tag (true in Performance, false elsewhere)

Compiled .pex are produced by CI (Commit Compiled Scripts step).

Implements the MCM portion of DaymareOn/hdtSMP64#376.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@DaymareOn, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 36 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 90389ae8-eb4d-46fe-95f4-635a922186eb

📥 Commits

Reviewing files that changed from the base of the PR and between 1e89897 and 77706f9.

📒 Files selected for processing (8)
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configs.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/2.5.1 Default.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Debug.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Default.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Performance.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Quality.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Reasonable.xml
  • Source/Scripts/FSMPM.psc
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/skip-dead-actors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DaymareOn
DaymareOn merged commit 6596bfe into main Jun 21, 2026
2 checks passed
@DaymareOn
DaymareOn deleted the feat/skip-dead-actors branch June 21, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant