publish readiness prep - #2
Merged
Merged
Conversation
The transport and idiom helpers that involve no n8n runtime, no I/O and no state move into their own module so they can be unit-tested directly. Two of them have already cost live debugging cycles — the tasks.wait envelope shape (a direct tools/call returns the task record at the top of structuredContent, only the discovery.perform wrapper nests it under .result) and the free-text tool-name resolver. Behaviour is unchanged; the node file drops from 648 to 534 lines.
40 tests via node:test with native TypeScript type-stripping, so the package's dependency tree — deliberately empty at runtime — is untouched. Covers the two subtle ones deliberately: taskRecord against both live envelope shapes, and resolveToolName's contract that it resolves confidently or resolves to nothing (an ambiguous or too-short fragment must return the catalogue rather than silently run a different tool).
Tests that do not run in CI rot.
n8n Cloud's no-dependencies rule rejects node:test imports, but it is about the node's shipped runtime — tests are never published (files: ["dist"]) and tsconfig compiles credentials/ and nodes/ only.
Abica
force-pushed
the
chore/publish-readiness
branch
from
August 12, 2026 06:26
2321c50 to
1f86086
Compare
prepublishOnly ran build and lint but not the tests, so a publish could ship with a failing suite. Verified both ways: a clean run executes the tests before build, and a failing test aborts the run before build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.