add additional exposure tests for ffe product to cover deduplication #5868

leoromanovsky · 2025-12-12T14:08:49Z

Motivation

Through manual inspection we noticed some undesired behavior in a few SDKs around exposure deduplication and logging; following up on this investigation we found that the system tests were missing this core behavior validation and the individual trace sdks had inconsistent validation. Centralizing here is the best way to enforce the desired behavior.

Changes

Adds additional tests to cover the various conditions:

  | Test Class                                   | What it Tests                     | Exposures |
  |----------------------------------------------|-----------------------------------|-----------|
  | Test_FFE_Exposure_Caching_Same_Subject       | Same subject, same flag, 5x       | 1         |
  | Test_FFE_Exposure_Caching_Different_Subjects | 5 different subjects              | 5         |
  | Test_FFE_Exposure_Caching_Allocation_Cycle   | alloc-a → alloc-b → alloc-a       | 3         |
  | Test_FFE_Exposure_Caching_Variant_Cycle      | variant-a → variant-b → variant-a | 3         |
  | Test_FFE_Exposure_Missing_Flag               | flag not in config, 3x            | 0         |
  | Test_FFE_Exposure_DoLog_False                | doLog=false, 3x                   | 0         |

These SDKs need to be corrected before merging this system test:

python (note: merged to main, going out in 4.0.2)
golang (note: merged to main, going out in 2.5.0)

Workflow

⚠️ Create your PR as draft ⚠️
Work on you PR until the CI passes
Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner.
- Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

If PR title starts with [<language>], double-check that only <language> is impacted by the change
No system-tests internal is modified. Otherwise, I have the approval from R&P team
A docker base image is modified?
- the relevant build-XXX-image label is present
A scenario is added (or removed)?
- Get a review from R&P team

github-actions · 2025-12-12T14:09:17Z

CODEOWNERS have been resolved as:

tests/ffe/test_exposures.py                                             @DataDog/feature-flagging-and-experimentation-sdk @DataDog/system-tests-core
utils/build/docker/ruby/rails72/Gemfile                                 @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails72/app/controllers/internal_controller.rb  @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails72/app/controllers/open_feature_controller.rb  @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/docker/ruby/rails72/config/routes.rb                        @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core

## Description  This fixes feature flags exposure logging according to [requirements](https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/5906009399/FFE+SDK+requirements) and [new system tests](DataDog/system-tests#5868). ## Testing  Updated python tests but haven't tested with system tests. ## Risks  I guess none ## Additional Notes  --------- Co-authored-by: Leo Romanovsky <[email protected]>

This fixes feature flags exposure logging according to [requirements](https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/5906009399/FFE+SDK+requirements) and [new system tests](DataDog/system-tests#5868).  Updated python tests but haven't tested with system tests.  I guess none  --------- Co-authored-by: Leo Romanovsky <[email protected]> (cherry picked from commit 1dcf5d1)

…5714)  This fixes feature flags exposure logging according to [requirements](https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/5906009399/FFE+SDK+requirements) and [new system tests](DataDog/system-tests#5868).  Updated python tests but haven't tested with system tests.  I guess none  --------- (cherry picked from commit 1dcf5d1) ## Description  ## Testing  ## Risks  ## Additional Notes  Co-authored-by: Oleksii Shmalko <[email protected]>

utils/build/docker/ruby/rails72/Gemfile

utils/build/docker/ruby/rails72/app/controllers/internal_controller.rb

utils/build/docker/ruby/rails72/app/controllers/open_feature_controller.rb

utils/build/docker/ruby/rails72/config/routes.rb

manifests/ruby.yml

utils/build/docker/ruby/parametric/server.rb

- Add test_exposures.py with tests for FFE exposure event caching and deduplication - Add /ffe/start endpoint to Ruby rails72 weblog to initialize OpenFeature provider - Update routes from /ffe to /ffe/start and /ffe/evaluate - Fix typos in comments (FFL -> FFE, "is have" -> "has") - Update python manifest version for exposure tests

This fixes feature flags exposure logging according to [requirements](https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/5906009399/FFE+SDK+requirements) and [new system tests](DataDog/system-tests#5868).  Updated python tests but haven't tested with system tests.  I guess none  --------- Co-authored-by: Leo Romanovsky <[email protected]> (cherry picked from commit 1dcf5d1)

utils/build/docker/ruby/rails72/app/controllers/open_feature_controller.rb

manifests/python.yml

utils/build/docker/ruby/rails72/app/controllers/open_feature_controller.rb

tests/ffe/test_exposures.py

# Conflicts: # manifests/python.yml

- Revert Python exposures test to bug (FFL-1623) since issue is still open - Use fetch_float_value instead of fetch_number_value in Ruby for consistency - Move UFC_EXPOSURE_DOLOG_FALSE_FIXTURE closer to Test_FFE_Exposure_DoLog_False

## Description  This fixes feature flags exposure logging according to [requirements](https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/5906009399/FFE+SDK+requirements) and [new system tests](DataDog/system-tests#5868). ## Testing  Updated python tests but haven't tested with system tests. ## Risks  I guess none ## Additional Notes  --------- Co-authored-by: Leo Romanovsky <[email protected]>

Strech

👏🏼

dd-oleksii mentioned this pull request Dec 17, 2025

fix(ffe): fix exposure logging according to requirements DataDog/dd-trace-py#15686

Merged

leoromanovsky mentioned this pull request Dec 17, 2025

feat(openfeature): add LRU cache for exposure deduplication DataDog/dd-trace-go#4290

Merged

7 tasks

leoromanovsky mentioned this pull request Dec 18, 2025

fix(ffe): fix exposure logging according to requirements (#15686) DataDog/dd-trace-py#15714

Merged

leoromanovsky force-pushed the lr/ffe-test-exposure-cache branch 6 times, most recently from 1a6d23e to 39dd02c Compare December 19, 2025 02:47

leoromanovsky changed the base branch from main to ffl-1320-add-feature-flags-to-weblog December 19, 2025 02:47

leoromanovsky force-pushed the lr/ffe-test-exposure-cache branch from 39dd02c to 92b8da1 Compare December 19, 2025 03:13

leoromanovsky marked this pull request as ready for review December 19, 2025 03:13

leoromanovsky requested review from a team as code owners December 19, 2025 03:13

leoromanovsky requested review from a team, KowalskiThomas and P403n1x87 and removed request for a team December 19, 2025 03:13

leoromanovsky assigned dd-oleksii Dec 19, 2025

Base automatically changed from ffl-1320-add-feature-flags-to-weblog to main December 19, 2025 03:21

leoromanovsky requested review from a team as code owners December 19, 2025 03:21

dd-oleksii reviewed Dec 19, 2025

View reviewed changes

leoromanovsky force-pushed the lr/ffe-test-exposure-cache branch 2 times, most recently from 2849bc8 to e427aba Compare December 19, 2025 13:46

cbeauchesne reviewed Dec 19, 2025

View reviewed changes

utils/build/docker/ruby/parametric/server.rb Show resolved Hide resolved

leoromanovsky force-pushed the lr/ffe-test-exposure-cache branch from a8c948f to c1592cf Compare December 19, 2025 18:21

leoromanovsky added 2 commits December 19, 2025 13:39

Fix: use fetch_float_value instead of fetch_numeric_value

b98f871

leoromanovsky mentioned this pull request Dec 19, 2025

fix(ffe): fix exposure logging according to requirements (#15686) DataDog/dd-trace-py#15739

Draft

leoromanovsky force-pushed the lr/ffe-test-exposure-cache branch from c1592cf to b98f871 Compare December 19, 2025 21:37

leoromanovsky commented Dec 19, 2025

View reviewed changes

utils/build/docker/ruby/rails72/app/controllers/open_feature_controller.rb Show resolved Hide resolved

fetch_number_value

78938b2

dd-oleksii reviewed Dec 23, 2025

View reviewed changes

manifests/python.yml Outdated Show resolved Hide resolved

utils/build/docker/ruby/rails72/app/controllers/open_feature_controller.rb Outdated Show resolved Hide resolved

tests/ffe/test_exposures.py Show resolved Hide resolved

tests/ffe/test_exposures.py Outdated Show resolved Hide resolved

leoromanovsky added 3 commits January 5, 2026 10:14

Merge branch 'main' into lr/ffe-test-exposure-cache

dc7e637

# Conflicts: # manifests/python.yml

Address PR review feedback from dd-oleksii

499d4b1

- Revert Python exposures test to bug (FFL-1623) since issue is still open - Use fetch_float_value instead of fetch_number_value in Ruby for consistency - Move UFC_EXPOSURE_DOLOG_FALSE_FIXTURE closer to Test_FFE_Exposure_DoLog_False

Keep Python exposures test enabled (v4.2.0-dev) per origin/main

67ed826

Strech approved these changes Jan 6, 2026

View reviewed changes

cbeauchesne approved these changes Jan 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add additional exposure tests for ffe product to cover deduplication #5868

add additional exposure tests for ffe product to cover deduplication #5868

leoromanovsky commented Dec 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Strech left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

add additional exposure tests for ffe product to cover deduplication #5868

Are you sure you want to change the base?

add additional exposure tests for ffe product to cover deduplication #5868

Conversation

leoromanovsky commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Workflow

Reviewer checklist

Uh oh!

github-actions bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Strech left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

leoromanovsky commented Dec 12, 2025 •

edited

Loading

github-actions bot commented Dec 12, 2025 •

edited

Loading